Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testExecutable signature in documentation #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ValentinVignal
Copy link

In flutter/packages#7546 I discovered that the signature of testExecutable should be

Future<void> testExecutable(FutureOr<void> Function() testMain)

to be able to compile the tests for the chrome platform.

This PR updates the documentation.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@ValentinVignal
Copy link
Author

cc @polina-c

@ValentinVignal
Copy link
Author

I believe this doesn't need a CHANGELOG entry/version bump/tests ?

Copy link

auto-submit bot commented Sep 9, 2024

auto label is removed for dart-lang/leak_tracker/245, due to This PR has not met approval requirements for merging. The PR author is not a member of dart-team and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@polina-c
Copy link
Contributor

polina-c commented Sep 9, 2024

Yes, no changelog is needed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants