Change the type of google3WorkspaceRoot to String.

This is a followup to https://dart-review.googlesource.com/c/sdk/+/383901 Remove the temporary backward compatibility now that users of this function has all been migrated. Bug: b/364942683 Change-Id: I8f951c6eb143497fb9edbf1465417d121a1cbf72 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384827 Auto-Submit: Chingjun Lau <[email protected]> Commit-Queue: Ben Konyi <[email protected]> Reviewed-by: Ben Konyi <[email protected]>
dart-lang · Sep 13, 2024 · 2483d30 · 2483d30
1 parent 8f6ead1
commit 2483d30
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/pkg/dds/lib/dds_launcher.dart b/pkg/dds/lib/dds_launcher.dart
@@ -53,12 +53,8 @@ class DartDevelopmentServiceLauncher {
     bool enableServicePortFallback = false,
     List<String> cachedUserTags = const <String>[],
     String? dartExecutable,
-    // TODO(chingjun): Change the type to String once flutter_tools is migrated.
-    Object? google3WorkspaceRoot,
+    String? google3WorkspaceRoot,
   }) async {
-    assert(google3WorkspaceRoot == null ||
-        google3WorkspaceRoot is Uri ||
-        google3WorkspaceRoot is String);
     final process = await Process.start(
       dartExecutable ?? Platform.executable,
       <String>[