Skip to content

Commit

Permalink
[ddc] fix windows tests for dynamic modules.
Browse files Browse the repository at this point in the history
Using toFilePath produces an absolute path with `c:` some of our snapshots (like kenrel_worker) don't know how to parse.

Using the URI string representation includes the scheme and addresses the issues (eg. example failure from before  https://dart-ci.appspot.com/log/ddc-win-chrome/ddc-win-chrome/6835/dynamic_modules_suite/shared_const)

Change-Id: Id71faf7745e5843cff6fa06fd198576b7560acf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/385301
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Sigmund Cherem <[email protected]>
  • Loading branch information
sigmundch authored and Commit Queue committed Sep 13, 2024
1 parent 7b47c74 commit cb4aedd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pkg/dynamic_modules/test/runner/ddc.dart
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ class DdcExecutor implements TargetExecutor {
'--no-summarize',
'--no-source-map',
'--multi-root',
sourceDir.resolve('../../').toFilePath(),
'${sourceDir.resolve('../../')}',
'--multi-root-scheme',
rootScheme,
'$rootScheme:/data/$testName/$source',
'--dart-sdk-summary',
ddcSdkOutline.toFilePath(),
'$ddcSdkOutline',
// Note: this needs to change if we ever intend to support packages within
// the dynamic loading tests themselves
'--packages=${repoRoot.toFilePath()}/.dart_tool/package_config.json',
Expand All @@ -100,12 +100,12 @@ class DdcExecutor implements TargetExecutor {
'--target',
'ddc',
'--multi-root',
sourceDir.resolve('../../').toFilePath(),
'${sourceDir.resolve('../../')}',
'--multi-root-scheme',
rootScheme,
'--packages-file=${repoRoot.toFilePath()}/.dart_tool/package_config.json',
'--dart-sdk-summary',
ddcSdkOutline.toFilePath(),
'$ddcSdkOutline',
'--source',
'$rootScheme:/data/$testName/$source',
'--output',
Expand Down

0 comments on commit cb4aedd

Please sign in to comment.