Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy_partitions when used with static partitions #1351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix copy_partitions when used with static partitions #1351

wants to merge 1 commit into from
+109 −26

Conversation

Kayrnt
Copy link
Contributor

@Kayrnt Kayrnt commented Sep 21, 2024

resolves #1349
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

The copy_partitions was originally designed for dynamic partitions but it can be adapted for static partitions which is done in that PR.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@Kayrnt Kayrnt requested a review from a team as a code owner September 21, 2024 19:39
@cla-bot cla-bot bot added the cla:yes label Sep 21, 2024
Kayrnt
Kayrnt commented Sep 21, 2024
View reviewed changes
tests/functional/adapter/incremental/incremental_strategy_fixtures.py
materialized="incremental",
incremental_strategy='insert_overwrite',
cluster_by="id",
partitions=["CAST('2020-01-02' AS DATE)","'2020-01-02'"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to be sure that it works with a "static" partition which is using a function

@github-christophe-oudar github-christophe-oudar mentioned this pull request Sep 21, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] copy_partitions with static partitions list produces empty statement
1 participant
@Kayrnt