Fix split part negative part number #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dave-connors-3, is there a way to test that? A test that should have been failing before but was missing ;) |
Fleid
added
the
ready_for_review
|
@Fleid the base test case was missing a case where the arg was negative 😓 the associated core PR adds it! |
|
@Fleid (which is here: dbt-labs/dbt-core#7200) |
|
Will try to squeeze in 1.5.0 but that looks tight :/ |
dbeatty10
reviewed
Jul 11, 2023
dbeatty10
reviewed
Jul 11, 2023
dbeatty10
changed the title
mikealfare
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #615
Description
Adds
part_numberto the second calculation when argument is negative to return the correct element from the array.Checklist
changie newto create a changelog entry