Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a column name for the customers schema in the jaffle example #10597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gliga
Copy link

@gliga gliga commented Aug 23, 2024

Resolves #

It would be an overkill for this change.

Problem

This PR fixes a typo in the jaffle example: one column was not named properly in the schema.

Solution

Update the name to match the one in the sql.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gliga gliga requested a review from a team as a code owner August 23, 2024 03:52
Copy link

cla-bot bot commented Aug 23, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @gliga

@github-actions github-actions bot added the community This PR is from a community member label Aug 23, 2024
@gliga
Copy link
Author

gliga commented Aug 23, 2024

In the message by the bot "above above" should be changed to "above".

@gliga
Copy link
Author

gliga commented Aug 23, 2024

Signed ClA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant