Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to get PDT working. #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

colevscode
Copy link

Fixing PDT to handle POST requests from paypal, more graceful error handling, and a security fix.
Tested on both sandbox and live Paypal servers.

Cole Krumbholz added 5 commits September 23, 2011 03:58
…PDT which won't store new pdt objects to the DB if they have invalid forms/postback responses, and 2) copy the txn_id over from the pdt GET method's tx parameter. This just makes invalid objects look better in the admin interface. (formerly they showed up as PDT: recurring since they didn't have a txn_id)
…d @require_GET decorator, since paypal is POSTing PDT data as of 09/23/2011

if not invalid_paypal_obj or \
not hasattr(settings, 'IGNORE_INVALID_PDT') or \
not settings.IGNORE_INVALID_PDT:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply if not invalid_paypal_obj or getattr(settings, 'IGNORE_INVALID_PDT', False)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants