added aperture photometry function to make_sz_cluster.py, called function in run_sims.ipynb #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
evavagiakis
previously approved these changes
Jul 26, 2023
evavagiakis
dismissed
their stale review
Conflicts have been introduced during this merge
|
Could you pull the current dev-massdist files @elaine-ran and only make changes to .py and .ipynb files before submitting another merge request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the tSZ_signal function to a new section of make_sz_cluster.py temporarily titled "other useful functions that have been tested" (alongside the m200 to r200 function). This function returns the average in the inner and outer radius, and the signal. I called the function in run_sims.ipynb, and plotted the corresponding circles with an inner radius R=2.1.