Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with masks #181

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix crash with masks #181

merged 1 commit into from
Sep 10, 2024

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Sep 10, 2024

@AGulev AGulev requested a review from Jhonnyg September 10, 2024 15:58
@@ -221,6 +221,7 @@ uint32_t CalcVertexBufferSize(const spSkeleton* skeleton, spSkeletonClipping* sk
{
CalcAndAddVertexBufferAttachment(attachment, &vertex_count, &max_triangle_count);
}
spSkeletonClipping_clipEnd(skeleton_clipper, slot);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we calculate buffer size, we should turn clipping off, otherwise vertex buffer size will be wrong

@AGulev AGulev merged commit a9d0b3b into main Sep 10, 2024
17 checks passed
@AGulev AGulev deleted the issue-9194_ branch September 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spine crash after animation completes
2 participants