build(refs T19759): update vuex to v4 [vue 3 upgrade] #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variouse stuff that had to be changed to see at least something. Now the fixing can begin.
# Conflicts: # yarn.lock
with vue3 the parent wasn't found anymore.
…nd remove click-outside - we have to fix that later. For now it only makes trouble
I don't get in wich version it has to be at the same element as the loop, and when It shal nopt be on template
…p.vue Co-authored-by: hwiem <[email protected]>
Co-authored-by: hwiem <[email protected]>
…p.html.twig Co-authored-by: hwiem <[email protected]>
- config.productionTip has been removed in vue 3 - in prod build, the tip will not show up see https://v3-migration.vuejs.org/breaking-changes/global-api.html#config-productiontip-removed
to remove a console warning, this option needs to be defined see https://vuejs.org/api/application.html#app-config-compileroptions-whitespace
it has been removed and is no longer needed
while these are set to the default values, defining them removes a console warning: vue.esm-bundler.js:6776 You are running the esm-bundler build of Vue. It is recommended to configure your bundler to explicitly replace feature flag globals with boolean literals to get proper tree-shaking in the final bundle. See http://link.vuejs.org/feature-flags for more details.
Vue.prototype is no longer available in vue 3. Instead, app.config.globalProperties should be used see https://v3-migration.vuejs.org/breaking-changes/global-api.html#a-new-global-api-createapp
in vue 3, the hooks in directives have changed: bind -> beforeMount inserted -> mounted update -> updated componentUpdated -> updated unbind -> unmounted
it has been removed and is no longer needed
SearchAndSorting doesn't have a hasChangedStatements prop, so it was added as an attribute. I could not find any usage of it, so I believe that it was added here accidentally and can simply be removed
in vue 3, html attributes need to be set to null instead of false to be removed
in vue 3, the beforeDestroy hook is replaced with beforeUnmount
…o_f_vue3_fixes # Conflicts: # client/js/components/procedure/admin/AdministrationProceduresList.vue # client/js/components/statement/assessmentTable/SearchModal/SearchModal.vue # package.json # templates/bundles/DemosPlanCoreBundle/Extension/contextual_help.html.twig # yarn.lock
in vue 3, watchers for arrays are not deep by default, so the option needs to be set
- add empty lines before `if` and `return` as well as after variable declarations - rename parameter in catch blocks to avoid confusion - make error messages more specific - remove unused parameter - remove obsolete comment
we don't need to include vue-multiselect in our dependencies as it is imported and used in demosplan-ui
- link to most recent commit in the corresponding demosplan-ui branch for testing purposes
# Conflicts: # yarn.lock
after the changes in demos-europe/demosplan-ui#650, the usage of DpTab.vue needs to be adjusted - an `isActive` prop needs to be passed to it
for testing purposes only
- to work with vue 3, vuex needs to be updated to v4 - new Store() is now createStore() - vue/compat and vue/compiler-sfc need to be updated to make things work - vue-template-compiler is only needed in vue 2, so it can be removed - dependencies need to be updated in demosplan-ui and vuex-json-api, too: - demos-europe/demosplan-ui#658 - eFrane/vuex-json-api#534
hwiem
added
the
review:frontend
Merged
3 tasks
in vue 3, events emitted from a component need to be declared via the 'emits' option
in vue 3, dynamic imports need to be wrapped in a `defineAsyncComponent()`
for testing purposes, demosplan-ui and vuex-json-api need to be set to the most recent commit in the feature branches needed for the vuex update
…up_into_f_T19759_vuex_update # Conflicts: # client/js/components/statement/assessmentTable/DpFilterModal.vue # client/js/components/statement/assessmentTable/DpMoveStatementModal.vue # package.json # yarn.lock
Co-authored-by: salisdemos <[email protected]>
salisdemos
approved these changes
Dec 6, 2023
the corresponding feature branch in demosplan-ui (f_T19759_update_vue_deps) has been merged into the integration branch
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration branch: #1151
Ticket: https://yaits.demos-deutschland.de/T19759
new Store()is nowcreateStore()vue/compatandvue/compiler-sfcneed to be updated to make things workvue-template-compileris only needed in vue 2, so it can be removed (in theory it's still needed for vue-test-utils because we didn't upgrade to the vue 3 version of it yet - we'll fix that later)demosplan-uiandvuex-json-api, too:How to review/test
cd node_modules/@demos-europe/demosplan-ui && yarn && yarn build:tokens && yarn build:prodyarn dev:<project>Linked PRs (optional)
PR Checklist