fix(refs DPLAN-12407): fix spacings and alignments #3699
Conversation
c-at-item__row was applying a width of 100%-31px, which lead to the table header elements being displaced to the left
- the logical hierarchy is still a bit messed up, but the "gislayer" heading is more important than its subheadings (overlays, base layers), and the h2 was missing in this view altogether
- lots of spacings (below/above buttons and other elements) and alignments (of icons) were not consistent or shifted - the checkbox in the table is given a margin-right of 27px so it aligns with the icon in the table header, but this does not work for mobile devices - the entire view is not optimized for mobile devices, and this should be fixed separately
hwiem
added
the
review:frontend
| {{ Translator.trans('map.base.minimap') }} | ||
| </h3> | ||
| <div class="w-2/3"> | ||
| <div> | ||
| <p class="font-size-small"> |
There was a problem hiding this comment.
We can already use tw classes on font size, they are configured to match our font scale.
| <p class="font-size-small"> | |
| <p class="text-sm"> |
There was a problem hiding this comment.
This will change the font-size from 15px to 14px. Do we want that?
There was a problem hiding this comment.
sure that it is 15px? the selector is defined here, and the variable is imported from demosplan-ui where it gets generated from this token which aliases to fontSize.scale.2 which is also 14px. Am i missing something, or does the value get overridden somewhere?
| @@ -248,7 +248,7 @@ export default { | |||
| return { | |||
| drag: false, | |||
| preventActiveFromToggeling: false, | |||
| iconClass: 'fa with--40 u-ml u-mr', | |||
| iconClass: 'mb-0 u-ml', | |||
There was a problem hiding this comment.
TW margin would be:
| iconClass: 'mb-0 u-ml', | |
| iconClass: 'mb-0 ml-4', |
A note on that: as i see, TW does not feature default steps in their margin- or padding scale, that means we cannot go just mt or p. Do we want that? Then i could add those classes to the TW config.
There was a problem hiding this comment.
I think it would be nice to have mb instead of mb-1 (etc.) 👍
There was a problem hiding this comment.
Ok! However as i see the u-m(b|t|r)-0_5 (12px) is the most used spacing step by far, so i'd opt to make that the default step.
templates/bundles/DemosPlanCoreBundle/DemosPlanMap/map_admin_gislayer_list.html.twig
Outdated
Show resolved
Hide resolved
templates/bundles/DemosPlanCoreBundle/DemosPlanMap/map_admin_gislayer_list.html.twig
Outdated
Show resolved
Hide resolved
after removing the legend, we should remove the fieldset, too, since a fieldset without legend is less accessible
the only styling really needed here is display: inline-block
Ticket
https://demoseurope.youtrack.cloud/issue/DPLAN-12407/Grundkarten-Auge-Icon-und-Bearbeiten-sind-verrutscht-und-da-gibt-keine-Padding-fur-Ubersichtskarte
Lots of spacings and alignments are fixed in the planning documents view:
How to review/test
PR Checklist