test: 인증 단위 테스트 구현 #202
Merged
test: 인증 단위 테스트 구현 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ddingmin
reviewed
Feb 12, 2024
| @@ -31,7 +30,7 @@ public class JwtAuthenticationFilter extends OncePerRequestFilter { | |||
| private final JwtProperty jwtProperty; | |||
|
|
|||
| @Override | |||
| protected void doFilterInternal(HttpServletRequest request, | |||
| public void doFilterInternal(HttpServletRequest request, | |||
There was a problem hiding this comment.
테스트 때문에 열어둔거면 @VisibleForTesting 붙여주면 좋을것 같습니당
ddingmin
reviewed
Feb 12, 2024
Comment on lines
1
to
+5
| package net.teumteum.unit.user.service; | ||
|
|
||
| import static net.teumteum.unit.auth.common.SecurityValue.VALID_ACCESS_TOKEN; | ||
| import static net.teumteum.unit.auth.common.SecurityValue.VALID_REFRESH_TOKEN; | ||
|
|
||
| import static net.teumteum.unit.common.SecurityValue.VALID_ACCESS_TOKEN; | ||
| import static net.teumteum.unit.common.SecurityValue.VALID_REFRESH_TOKEN; |
ddingmin
approved these changes
Feb 12, 2024
ddingmin
added a commit
that referenced
this pull request
Feb 12, 2024
* test: test 명 완성 * refactor: Instant를 모두 LocalDateTime으로 변경 (#200) * fix: 알림이 가지 않는 버그 수정 * �test: 인증 단위 테스트 구현 (#202) * refactor: JwtAuthenticationFilter 불필요한 로직 제거 (#198) * refactor: SecurityValue 패키지 이동 (#198) * test: 인증 관련 단위 테스트 구현 (#198) * test: 인증 관련 단위 테스트 구현 (#198) * test: JwtAuthenticationFilterTest 리팩토링 (#198) * feat: 로그인한 유저가 북마크한 모임 조회 (#204) * feat: 로그인한 유저가 북마크한 모임 조회 * test: 테스트 코드에 로그인 로직 추가 --------- Co-authored-by: choidongkuen <[email protected]> Co-authored-by: devxb <[email protected]> Co-authored-by: xb205 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 개발했나요?
🕶️ 어떻게 해결했나요?
🦀 이슈 넘버