KVM --disksize option to grow target disk image #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK needs rebase |
devrandom
reviewed
May 1, 2018
target-bin/complete-resize.sh
Outdated
|
|
||
| DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends -y install expect-dev parted | ||
| swapoff -a | ||
| { cat <<\EOF; sleep 1; while pidof parted; do sleep 1; done; } | unbuffer -p parted /dev/vda |
There was a problem hiding this comment.
why was there a need for this wait?
target-bin/complete-resize.sh
Outdated
| DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends -y install expect-dev parted | ||
| swapoff -a | ||
| { cat <<\EOF; sleep 1; while pidof parted; do sleep 1; done; } | unbuffer -p parted /dev/vda | ||
| rm 2 |
There was a problem hiding this comment.
is this swap? a bit worried it might break some builds that were on the edge with memory. are you thinking swap is generally not needed?
This is needed for users with larger caches.
|
Rebased, but changed it from a YML option to a command-line gbuild option, since it is primarily dependent on user cache size. |
luke-jr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build Talos II firmware in gitian, but hitting disk space issues.
For now, this lets the yml file choose a larger disk size. Only supported in KVM.