Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at a document on idempotency #3462

Merged
merged 16 commits into from
Sep 20, 2024

Conversation

oggy-dfin
Copy link
Member

@oggy-dfin oggy-dfin commented Sep 12, 2024

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

@oggy-dfin oggy-dfin marked this pull request as ready for review September 12, 2024 15:03
@oggy-dfin oggy-dfin requested a review from a team as a code owner September 12, 2024 15:03
sidebars.js Outdated Show resolved Hide resolved
Copy link
Contributor

@derlerd-dfinity derlerd-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

Copy link
Contributor

@robin-kunzler robin-kunzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @oggy-dfin , thanks a lot for putting in the work!

Really like the explicit listing of advantages and disadvantages for the sequence numbers and deduplication approaches. This makes it much clearer.

Approving, left a few mostly minor comments / questions below.

@oggy-dfin oggy-dfin merged commit 779e0b7 into dfinity:master Sep 20, 2024
4 checks passed
@oggy-dfin oggy-dfin deleted the oggy-idempotency branch September 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants