Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add movie data set with GraphQL schema #41

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Aug 27, 2020

This PR adds the following files for a movie data set for Dgraph GraphQL:

  • 19million.rdf.gz
  • 19million.schema
  • schema.graphql

The 19million.rdf.gz was created from the 21million.rdf.gz with the human-language @lang support removed, since GraphQL doesn't currently support human languages.

The GraphQL schema uses the @dgraph directive for all the fields to use the original movie data set fields as-is.


This change is Reviewable

* No @lang directives in Dgraph schema.
* No @count directives in Dgraph schema to avoid time waiting for it to be
removed when setting the GraphQL schema.
* Use removelangs.go to filter out language strings. Only keep the English ones.
* simple.graphql is a basic GraphQL schema with a subset of the fields from the
movie dataset.
This file is for reference purposes only. It's not ready as-is to be used as a
GraphQL schema.

1. The types aren't the same names as the Dgraph types.
2. Reverse edges aren't set properly.
3. GraphQL directives aren't used.
4. Other things too.
curl http://localhost:8080/admin/schema --upload-file ./schema.graphql

{"errors":[{"message":"resolving updateGQLSchema failed because input:200: Type FestivalSponsorship; Field festivals: has type [Film], which is different to type FestivalSponsor; field festivals, which has the same @dgraph directive but type [Festival]. These fields must have either the same GraphQL types, or use different Dgraph predicates.\ninput:329: Type PersonalAppearance; Field appearances: has type [PersonalAppearanceType], which is different to type Performance; field appearances, which has the same @dgraph directive but type [PersonalAppearance]. These fields must have either the same GraphQL types, or use different Dgraph predicates.\n (Locations: [{Line: 3, Column: 4}])","extensions":{"code":"Error"}}]}
This was used during testing instead of the entire schema.graphql.
GraphQL doesn't support geo types, and theese two predicates don't
exist in the 19miillion.rdf.gz dataset anyway. These were
taken from the release/21miillion.schema file.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rarvikar rarvikar self-requested a review January 19, 2023 18:25
Copy link

This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants