Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plural field for alternative words and plural articles #518

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Add plural field for alternative words and plural articles #518

merged 1 commit into from
Apr 13, 2024

Conversation

MizukiTemma
Copy link
Member

Short description

This PR adds plural field for alternative words and plural articles for main and alternativ words

Proposed changes

  • Add wished fields
  • Add a new set of choices for plural article
  • Rename some fields to distinguish plural article and singular article
  • Adjust test data

Resolved issues

Fixes: #516

@MizukiTemma MizukiTemma requested a review from a team as a code owner April 11, 2024 13:26
@MizukiTemma MizukiTemma force-pushed the feature/alternative_plural_and_plural_article branch from 0ad772a to c96b7e0 Compare April 11, 2024 13:31
@MizukiTemma
Copy link
Member Author

@roman-digitalfabrik
The current implementation looks like this (see screenshots below)

Let me know if something is missing.

1
2
3

@MizukiTemma MizukiTemma force-pushed the feature/alternative_plural_and_plural_article branch from df45134 to e5b7a03 Compare April 12, 2024 10:01
JoeyStk
JoeyStk approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
To me it looks good. I know we still had an on-going discussion about this, but since no conclusion was found, I think we can do it like this :)

@MizukiTemma MizukiTemma force-pushed the feature/alternative_plural_and_plural_article branch from cef72ba to 49c5148 Compare April 13, 2024 16:43
@MizukiTemma MizukiTemma mentioned this pull request Apr 13, 2024
Open
@MizukiTemma MizukiTemma merged commit eef4873 into develop Apr 13, 2024
1 check passed
@MizukiTemma MizukiTemma deleted the feature/alternative_plural_and_plural_article branch April 13, 2024 16:50
@LeandraH LeandraH mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyStk JoeyStk JoeyStk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MizukiTemma @JoeyStk