Adding Macaroon V2 impl #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @doawoo I've updated the version handling and added a few tests for binary serializer. lmk if you have any feedback. |
|
Hey there! I'm taking a look at this PR in chunks now! Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements macaroons V2 spec as defined here, and leaning on the Python pymacaroons lib and Golang go-macaroons lib. Wrote this to work on a separate project, but I think it's close to workable.
Curious if prior work was done for V2. If this seems directionally correct, and there's interest in adding it to this lib, I'll clean it up a further and add tests.
Let me know your thoughts. Thanks!