Migrate more images to the new build system #78
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelines
reviewed
Sep 10, 2024
| @@ -5,34 +5,29 @@ def repos_anti_subset: | |||
| [ | |||
| # as we remove items from this list, we need to be careful that none of their *children* are still in the list | |||
| # (which is why this is sorted in rough "build order" -- that means we can ~safely "pop" off the bottom) | |||
| "clearlinux", | |||
| "couchbase", | |||
| "buildpack-deps", # direct children: erlang gcc golang haskell haxe influxdb kapacitor node openjdk perl pypy python rakudo-star ruby rust telegraf | ||
| "couchbase", | ||
|
|
||
| "debian", # direct children: aerospike buildpack-deps chronograf clojure couchdb dart emqx erlang haproxy haskell hitch httpd influxdb irssi julia maven memcached mono mysql neo4j neurodebian nginx node odoo openjdk perl php postgres pypy python r-base redis rethinkdb rocket.chat ruby rust spiped swipl unit varnish |
There was a problem hiding this comment.
Is there an intent to the reordering?
|
The intent of the reorder is to make the dependencies a bit more clear |
LaurentGoderre
force-pushed
the
migrate-new-build-2
branch
from
110c666
to
04233f2
Compare
|
Because it was a little hard for me to follow what was moved around in $ jq -n -L . 'include "doi"; include "doi-new"; repos_anti_subset - new_repos_anti_subset'
[
"ubuntu",
"buildpack-deps",
"eclipse-temurin",
"haskell",
"liquibase",
"rakudo-star",
"silverpeas"
]So, these will be the additions to the new build system. This seems fine to me once you are ready. 👍 |
|
I've had a go at adding rakudo-star here anchore/syft#3224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: