Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rakudo-star to 2024.03 #16567

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

AntonOks
Copy link
Contributor

@AntonOks AntonOks commented Apr 8, 2024

Adding a bookworm tag for consistency and clarity and switching the FROM alpine Docker image to "alpine:latest"...

Adding a bookworm tag for consistency and clarity and switching the FROM alpine Docker image to "alpine:latest"...
@AntonOks AntonOks requested a review from a team as a code owner April 8, 2024 20:04
Copy link

github-actions bot commented Apr 8, 2024

Diff for 00dde57:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index bd4a811..dff9002 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,12 +1,12 @@
 Maintainers: Moritz Lenz <[email protected]> (@moritz), Joelle Maslak <[email protected]> (@jmaslak), Daniel Mita <[email protected]> (@m-dango), Anton Oks <[email protected]> (@AntonOks)
 GitRepo: https://github.com/Raku/docker
 
-Tags: alpine, 2024.02-alpine
+Tags: alpine, 2024.03-alpine
 Architectures: amd64, arm64v8
-GitCommit: 1357b3acb550569e7ecf2da22fc32c32319fb872
-Directory: 2024.02/alpine3.19
+GitCommit: 64657bbc83c2536e3d2dcd8f075dde4e206b1421
+Directory: 2024.03/alpine
 
-Tags: latest, 2024.02
+Tags: latest, 2024.03, bookworm
 Architectures: amd64, arm64v8
-GitCommit: 1357b3acb550569e7ecf2da22fc32c32319fb872
-Directory: 2024.02/bookworm
+GitCommit: 64657bbc83c2536e3d2dcd8f075dde4e206b1421
+Directory: 2024.03/bookworm
diff --git a/_bashbrew-list b/_bashbrew-list
index f10ce1f..95bebd0 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,4 +1,5 @@
-rakudo-star:2024.02
-rakudo-star:2024.02-alpine
+rakudo-star:2024.03
+rakudo-star:2024.03-alpine
 rakudo-star:alpine
+rakudo-star:bookworm
 rakudo-star:latest
diff --git a/rakudo-star_2024.02-alpine/Dockerfile b/rakudo-star_2024.03-alpine/Dockerfile
similarity index 96%
rename from rakudo-star_2024.02-alpine/Dockerfile
rename to rakudo-star_2024.03-alpine/Dockerfile
index a795f1e..6378875 100644
--- a/rakudo-star_2024.02-alpine/Dockerfile
+++ b/rakudo-star_2024.03-alpine/Dockerfile
@@ -1,8 +1,8 @@
-FROM alpine:3.19
+FROM alpine:latest
 
 RUN addgroup -S raku && adduser -S raku -G raku
 
-ARG rakudo_version=2024.02-01
+ARG rakudo_version=2024.03-01
 ENV rakudo_version=${rakudo_version}
 
 RUN buildDeps=' \
diff --git a/rakudo-star_2024.02/Dockerfile b/rakudo-star_bookworm/Dockerfile
similarity index 98%
rename from rakudo-star_2024.02/Dockerfile
rename to rakudo-star_bookworm/Dockerfile
index 98f9c8b..c964c7a 100644
--- a/rakudo-star_2024.02/Dockerfile
+++ b/rakudo-star_bookworm/Dockerfile
@@ -3,7 +3,7 @@ MAINTAINER Rob Hoelz
 
 RUN groupadd -r raku && useradd -m -r -g raku raku
 
-ARG rakudo_version=2024.02-01
+ARG rakudo_version=2024.03-01
 ENV rakudo_version=${rakudo_version}
 
 RUN buildDeps=' \

Relevant Maintainers:

@tianon
Copy link
Member

tianon commented Apr 8, 2024

Switching to the implicit alpine:latest is what I like to call a "square wheel" -- it's technically a rolling tag, but when that square wheel rolls, you might experience some unexpected breakage as a result, so we recommend being explicit (and bumping manually when the wheel rolls and you've done at least a surface-level verification of compatibility).

@AntonOks
Copy link
Contributor Author

AntonOks commented Apr 8, 2024

Switching to the implicit alpine:latest is what I like to call a "square wheel" -- it's technically a rolling tag, but when that square wheel rolls, you might experience some unexpected breakage as a result, so we recommend being explicit (and bumping manually when the wheel rolls and you've done at least a surface-level verification of compatibility).

@tianon

Thanks for your hint / opinion. We discussed pro's and con's in Raku/docker#60 and part of that is my thoughts on this case here.

From my understanding, the "rakudo-star" container was supported, if at all, on a "personal and best effort level". I doubt there were "verification" or the like efforts done...

@tianon
Copy link
Member

tianon commented Apr 8, 2024

Ah nice, thank you for the references (and for already having thought about / discussed it) ❤️

@tianon tianon merged commit b23bcdb into docker-library:master Apr 8, 2024
7 checks passed
@AntonOks
Copy link
Contributor Author

AntonOks commented Apr 8, 2024

Switching to the implicit alpine:latest is what I like to call a "square wheel" -- it's technically a rolling tag, but when that square wheel rolls, you might experience some unexpected breakage as a result, so we recommend being explicit (and bumping manually when the wheel rolls and you've done at least a surface-level verification of compatibility).

Finally, it's about automating merge requests to this repo here... based on GitHub workflows in our "rako/docker" repo... If you have some nice-and-easy examples from other images here, which I / we could just copy-paste to get our rakudo-star "offical-images" up2date, including the "FROM" images of our Dockerfiles, I would be fine either way ;)

And finally, from my understanding and I may be very wrong here... our "bookwork" also points to a "somehow latest stable" and not an "explicit" version, right:

@AntonOks AntonOks deleted the patch-1 branch April 8, 2024 22:02
@tianon
Copy link
Member

tianon commented Apr 8, 2024

FROM buildpack-deps:bookworm-scm is explicitly Debian Bookworm (so when Trixie is released, it will not automatically update 😄)

For automating image update PRs, you'll want to review https://github.com/docker-library/faq#can-i-use-a-bot-to-make-my-image-update-prs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants