Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: templates/navigation overhaul #20916

Merged
merged 10 commits into from
Sep 17, 2024
Merged

site: templates/navigation overhaul #20916

merged 10 commits into from
Sep 17, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Sep 16, 2024 •
edited
Loading

Description

  • Update the header styles, gradient color
  • Revamp the layout architecture
  • Revamp the sidebar contents, and apply sidebar consistently
  • Add icons to the main nav items in the sidebar
  • Squash some bugs (e.g., hamburger menu unresponsive on some pages, titles not truncating in sidebar)

@dvdksn
site: update top navigation styles
d078a3b 
- use the full viewport width
- goodbye sad gray, hello fun blue
- nicer logo

Signed-off-by: David Karlsson <[email protected]>
@dvdksn
hugo: update layout architecture
4443d36 
Signed-off-by: David Karlsson <[email protected]>
@dvdksn
site: use common base layout in search layout
a2497ef 
Signed-off-by: David Karlsson <[email protected]>
@dvdksn
hugo: use comon base template in taxonomy layouts
d970c47 
Signed-off-by: David Karlsson <[email protected]>
@dvdksn
hugo: add main nav icons and fix mobile rendering
dd294db 
Signed-off-by: David Karlsson <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 52f9c17
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66e93b656eca720008256c8d
😎 Deploy Preview https://deploy-preview-20916--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/get-started Relates to get started and onboarding docs hugo Updates related to hugo dependencies Vendoring, packaging updates area/guides labels Sep 16, 2024
@dvdksn dvdksn requested a review from a team September 17, 2024 08:22
@dvdksn dvdksn marked this pull request as ready for review September 17, 2024 08:22
aevesdocker
aevesdocker approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice changes

@dvdksn dvdksn merged commit 2db1674 into docker:main Sep 17, 2024
14 checks passed
@dvdksn dvdksn deleted the blue-skies-navs branch September 17, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevesdocker aevesdocker aevesdocker approved these changes

Assignees
No one assigned
Labels
area/get-started Relates to get started and onboarding docs area/guides dependencies Vendoring, packaging updates hugo Updates related to hugo status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvdksn @aevesdocker