Enhancement/make selector sticky #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL * docs: update AzureBlobs to match refactor * Update `aiohttp` from 3.8.4 -> 3.8.5 * Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper * refactor: move document list management methods to `SpaceDataSourceFileBased` * add OpendalReader code + lic + copyright * refactor: DocumentListItem * change from `tuple` to a `dataclass` * move to domain.py * chore: remove commented code * test: * unit test DocumentListItem.create_instance * unit test consistency between document list save and load (serialise and de-serialise). * move test PDF doc folder * Various minor fixes: * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text. * pass args to DocumentListItem() in the correct order * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index. * style: fix style and lint errors BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working.
|
can you drop in screenshot of the full window so I can see what it looks like when a user is scrolled half up a long chat history |
|
@janaka |
|
@osala-eng ok. Lets still use the |
Okay |
janaka
reviewed
Aug 16, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
also can you bump llama index to the latest or if lots of breaking changes to something greater than v0.7.13 |
Okay. |
janaka
reviewed
Aug 21, 2023
janaka
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
@osala-eng left one comment about the function, once that's adjusted this should be good to go providing you have done sufficient testing.
osala-eng
added a commit
that referenced
this pull request
Aug 22, 2023
* feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Add custom styling for personal ask. * chore: Remove unused imports. * Refactor: azureblob datasource (#79) refactor: Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL * docs: update AzureBlobs to match refactor * Update `aiohttp` from 3.8.4 -> 3.8.5 * Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper * refactor: move document list management methods to `SpaceDataSourceFileBased` * add OpendalReader code + lic + copyright * refactor: DocumentListItem * change from `tuple` to a `dataclass` * move to domain.py * chore: remove commented code * test: * unit test DocumentListItem.create_instance * unit test consistency between document list save and load (serialise and de-serialise). * move test PDF doc folder * Various minor fixes: * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text. * pass args to DocumentListItem() in the correct order * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index. * style: fix style and lint errors BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working. * chore: Add avatar to chat messages * chore: Added script to format avartars. * feat: Make the space selector box stick to the top of the page. * chore: Remove unused imports. * Update user avatar settings. * chore: Attach event listeners to space selector. * chore: Cleanup imports. * chore: Update chat_ui script. * feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Use username as email for gravatar requests. * chore: Use identicon as avatar default * chore: Set username in auth session state. * chore: Cleanup imports. * chore: Bump llama-index to 0.8.5.post2 * Update get username function --------- Co-authored-by: Janaka Abeywardhana <[email protected]>
osala-eng
added a commit
that referenced
this pull request
Aug 25, 2023
* feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Add custom styling for personal ask. * chore: Remove unused imports. * Refactor: azureblob datasource (#79) refactor: Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL * docs: update AzureBlobs to match refactor * Update `aiohttp` from 3.8.4 -> 3.8.5 * Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper * refactor: move document list management methods to `SpaceDataSourceFileBased` * add OpendalReader code + lic + copyright * refactor: DocumentListItem * change from `tuple` to a `dataclass` * move to domain.py * chore: remove commented code * test: * unit test DocumentListItem.create_instance * unit test consistency between document list save and load (serialise and de-serialise). * move test PDF doc folder * Various minor fixes: * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text. * pass args to DocumentListItem() in the correct order * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index. * style: fix style and lint errors BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working. * chore: Add avatar to chat messages * chore: Added script to format avartars. * feat: Make the space selector box stick to the top of the page. * chore: Remove unused imports. * Update user avatar settings. * chore: Attach event listeners to space selector. * chore: Cleanup imports. * chore: Update chat_ui script. * feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Use username as email for gravatar requests. * chore: Use identicon as avatar default * chore: Set username in auth session state. * chore: Cleanup imports. * chore: Bump llama-index to 0.8.5.post2 * Update get username function --------- Co-authored-by: Janaka Abeywardhana <[email protected]>
osala-eng
added a commit
that referenced
this pull request
Aug 25, 2023
* feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Add custom styling for personal ask. * chore: Remove unused imports. * Refactor: azureblob datasource (#79) refactor: Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL * docs: update AzureBlobs to match refactor * Update `aiohttp` from 3.8.4 -> 3.8.5 * Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper * refactor: move document list management methods to `SpaceDataSourceFileBased` * add OpendalReader code + lic + copyright * refactor: DocumentListItem * change from `tuple` to a `dataclass` * move to domain.py * chore: remove commented code * test: * unit test DocumentListItem.create_instance * unit test consistency between document list save and load (serialise and de-serialise). * move test PDF doc folder * Various minor fixes: * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text. * pass args to DocumentListItem() in the correct order * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index. * style: fix style and lint errors BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working. * chore: Add avatar to chat messages * chore: Added script to format avartars. * feat: Make the space selector box stick to the top of the page. * chore: Remove unused imports. * Update user avatar settings. * chore: Attach event listeners to space selector. * chore: Cleanup imports. * chore: Update chat_ui script. * feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Use username as email for gravatar requests. * chore: Use identicon as avatar default * chore: Set username in auth session state. * chore: Cleanup imports. * chore: Bump llama-index to 0.8.5.post2 * Update get username function --------- Co-authored-by: Janaka Abeywardhana <[email protected]>
osala-eng
added a commit
that referenced
this pull request
Sep 4, 2023
* chore: Re-arrange admin docs layout. * chore: Update admin docs UI layout. * chore: Rename consolidated space to Admin Spaces. * Enhancement/make selector sticky (#84) * feat: Make the space selector box stick to the top of the page. * chore: Add custom styling for personal ask. * chore: Remove unused imports. * chore: Add an avatar to chat messages * chore: Added script to format avatars. * feat: Make the space selector box stick to the top of the page. * chore: Remove unused imports. * Update user avatar settings. * chore: Attach event listeners to space selector. * chore: Cleanup imports. * chore: Update chat_ui script. * feat: Make the space selector box stick to the top of the page. * chore: Use username as email for gravatar requests. * chore: Use identicon as avatar default * chore: Set username in auth session state. * chore: Bump llama-index to 0.8.5.post2 * Update get username function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, e.g. what the new feature # is and/or what bug # it fixes. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes/Implements #(issue/feature)
Added avatar support using
GravatarsMade space selector in the
Shared AskstaticCollapsed
Expanded
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.
Test Configuration:
Please describe the test setup. List them below as bullet points.
Checklist: