Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pki-server subsystem-cert-export #4739

Merged
merged 1 commit into from
May 13, 2024

Conversation

fmarco76
Copy link
Member

Solve the pki-server subsystem-cert-export error when trying to export a CSR.

Fix bz-2276139

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works but since this method is potentially used for various things I'd suggest to check if the CSR exists before loading it instead of ignoring the error and generating an error message because it could be confusing to the users. I think it would be better to let the caller (e.g. the CLI) generate an appropriate message if the CSR is missing. Feel free to update/merge.

Solve the pki-server subsystem-cert-export error when trying to export a
CSR.

Fix bz-2276139
Copy link

sonarcloud bot commented May 13, 2024

@fmarco76
Copy link
Member Author

Following previous comment the the code has been updated to avoid error log for missing csr file. If csr file is present then its content is added to the cert object otherwise no operation.

@edewata Thanks!

@fmarco76 fmarco76 merged commit f0b1c9c into dogtagpki:master May 13, 2024
140 of 147 checks passed
@fmarco76 fmarco76 deleted the FixExportCSR branch May 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants