Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for passwordFile and passwordClass #4740

Merged
merged 1 commit into from
May 13, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented May 11, 2024

The code that uses passwordFile and passwordClass params has been updated to use default values if these params are not specified, so it's no longer necessary to store these params in the CS.cfg. The PKISubsystem.create_conf() has also been modified to no longer add these params if they are missing.

The upgrade script has been updated to remove these params from existing instances if they contain the default values.

https://github.com/edewata/pki/blob/install/docs/changes/v11.6.0/Server-Changes.adoc

The code that uses passwordFile and passwordClass params has
been updated to use default values if these params are not
specified, so it's no longer necessary to store these params
in the CS.cfg. The PKISubsystem.create_conf() has also been
modified to no longer add these params if they are missing.

The upgrade script has been updated to remove these params
from existing instances if they contain the default values.
@edewata edewata requested a review from fmarco76 May 11, 2024 03:14
Copy link

sonarcloud bot commented May 11, 2024

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented May 13, 2024

@fmarco76 Thanks!

@edewata edewata merged commit 441657b into dogtagpki:master May 13, 2024
140 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants