-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move REST endpoint to v1 #4771
Move REST endpoint to v1 #4771
Conversation
e9b80d4
to
125edde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment, but it LGTM.
@@ -32,7 +34,7 @@ | |||
<security-constraint> | |||
<web-resource-collection> | |||
<web-resource-name>Agent Services</web-resource-name> | |||
<url-pattern>/rest/agent/*</url-pattern> | |||
<url-pattern>/v1/agent/*</url-pattern> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep the old URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep the old URL?
You are right, it is not needed. Removed!
125edde
to
e9ca483
Compare
The current REST implemenation is associated to /v1 path and the /rest path is a redirect to the /v1. This would make easier to switch between REST implementations.
The current rest APIs are moved to a subpackage named `v1`. The new implementation has moved to the subpackage `v1`. The new implementation has moved to the subpackage `v2`. This will simplify the selective building of REST implementation. Subsystems ACME and EST have not been modified because they use REST to implement the protocol and this requires extra effort.
e9ca483
to
511a307
Compare
Quality Gate failedFailed conditions |
@edewata Thanks! I have updated the path for the classes. |
The current REST implemenation is associated to /v1 path and the /rest path is a redirect to the /v1.
This would make easier to switch between REST implementations.