Add TKS TPSConnectorService to v2 APIs #4822
Conversation
fmarco76
force-pushed
the
TPSConnectorService_v2
branch
from
1468004
to
34257e5
Compare
|
| String host = request.getParameter("host"); | ||
| String port = request.getParameter("port"); |
There was a problem hiding this comment.
Just a note, we probably should consider requiring the user to specify the connector ID so that we don't have to generate it. The current findNextConnectorID() might not generate consistent IDs across the cluster which could be problematic.
There was a problem hiding this comment.
Yes, the current implementation of findNextConnectorID() does not work across a cluster. The user could provide the ID or we have to implement a way to get the information consistent in a cluster scenario. Do we create a ticket for this?
There was a problem hiding this comment.
This is a design issue, not just the API, but also the storage, which might not be trivial to fix. So far there's nobody asking to fix it so I'd just leave it as is for now. Maybe in the future when we fully move to containers this issue will come up again and we can redesign at that point.
|
@edewata Thanks! |
No description provided.