Cert validation changes in the latest NSS #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a client tries to connect to a server but it does not have the CA signing cert installed and trusted it will get an UNTRUSTED_ISSUER error from NSS and the cert approval callback will ask the user whether to trust the cert. In the latest NSS the error has changed to UNKNOWN_ISSUER, so the callback has been updated to handle the error in the same way. The tests have also been updated accordingly.
The latest NSS requires the client to have the full cert chain in order to validate a cert, so most of the sub CA tests have been updated to install the sub CA signing cert in addition to the root CA signing cert. For some reason the sub CA tests with HSM still work without these changes. That will be investigated separately later.
|
fmarco76
approved these changes
Aug 21, 2024
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a client tries to connect to a server but it does not have the CA signing cert installed and trusted it will get an
UNTRUSTED_ISSUERerror from NSS and the cert approval callback will ask the user whether to trust the cert. In the latest NSS the error has changed toUNKNOWN_ISSUER, so the callback has been updated to handle the error in the same way. The tests have also been updated accordingly.The latest NSS also requires the client to have the full cert chain in order to validate a cert, so most of the sub CA tests have been updated to install the sub CA signing cert in addition to the root CA signing cert. For some reason the sub CA tests with HSM still work without these changes. That will be investigated separately later.