Add test for ACME on separate instance #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new test has been added to install CA and ACME on separate instances using pkispawn, then perform some operations using certbot. The code that calls spawn_acme() has been moved to run after the instance is created by the instance_layout scriptlet. The code that checks the existence of pki_ds_password has been moved so that it will only run if pki_ds_setup is True. The code that checks the existence of pki_admin_password and pki_client_pkcs12_password has been updated so that it will not run for ACME.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new test has been added to install CA and ACME on separate instances using
pkispawn, then perform some operations usingcertbot.The code that calls
spawn_acme()has been moved to run after the instance is created by theinstance_layoutscriptlet.The code that checks the existence of
pki_ds_passwordhas been moved so that it will only run ifpki_ds_setupis True.The code that checks the existence of
pki_admin_passwordandpki_client_pkcs12_passwordhas been updated so that it will not run for ACME.