-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Centralize the logic to read feature flag values (#29900) #29904
base: master
Are you sure you want to change the base?
feat(api): Centralize the logic to read feature flag values (#29900) #29904
Conversation
Quality Gate passedIssues Measures |
Before merging this PR, I want to make sure that we have a real need to implement the filtering. Have we identified a real need from FE, support, etc? |
|
||
if (keysQuery != null && !keysQuery.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think StringUtils.isSet does this
|
||
if (keysQuery != null && !keysQuery.isEmpty()) { | ||
// Old behavior when keys parameter is provided | ||
final String[] keys = StringUtils.splitByCommas(keysQuery); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be perform with a Stream such as
Stream.of(key).map(this::removePrefix).filter....
resultMap.put(keyWithoutPrefix, recoveryFromConfig(key)); | ||
} | ||
} | ||
} else { | ||
// New filtering behavior | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this should be in another place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments but in general is a good improve for the configs
Proposed Changes
Things to think about
Checklist
Additional Info
This PR resolves #29900 (Centralize the logic to read feature flag values).
Screenshots