Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add templates for Aspire test projects #2905
Add templates for Aspire test projects #2905
Changes from 7 commits
9461cd3
c3b05f6
c6c6ed2
83d65f2
91f484b
ebaad83
367b278
ce12e7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice thing we do in our tests is:
aspire/tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs
Lines 38 to 41 in 9073e07
That way if it fails, you get the responseContent logged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we have resiliency on the HttpClient returned from CreateHttpClient, you can't actually do it quite like that, as if the status code wasn't a success status code, it will retry until it fails anyway. I think keeping this test in the template simple is probably best for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't resilience only retry on certain failures? If a service returns 500 (Internal Server Error), it wouldn't retry that, would it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm not sure, I thought a 500 is exactly the kind of thing it would retry, vs. a 300 or 400 status code. Obviously connection level issues would be retried too.