[dashpages] Dashpage layout improvements #5784
Merged
+27
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FluentGrid` uses `@media` queries for breakpoints, which work on the window size (viewport area). However we have a splitter in this UI, and dragging it should cause the dashpage area to relayout as the container size changes. This change removes `FluentGrid` and instead uses flexbox layout directly.
JamesNK
reviewed
Sep 19, 2024
| } | ||
|
|
||
| .dashpage-chart-grid .dashpage-chart-tile { | ||
| flex: 1 1 25%; |
There was a problem hiding this comment.
Could you add a small comment here that says what this does
There was a problem hiding this comment.
Can you explain what's unclear? Do you want me to explain how flex works?
There was a problem hiding this comment.
I don't know what 1 1 25% means. I'm more experienced with css grid than flex box and I'm guessing most people who see this won't know what it does.
There was a problem hiding this comment.
Ok I see. This doc summarizes it pretty well: https://developer.mozilla.org/en-US/docs/Web/CSS/flex
I'm not sure what comment we'd add, beyond linking to docs. There'll always be someone who isn't familiar with a language/platform/framework feature we're using, and we can't explain all of them.
adamint
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make dashpage responsive to container, not viewport
FluentGriduses@mediaqueries for breakpoints, which work on the window size (viewport area). However we have a splitter in this UI, and dragging it should cause the dashpage area to relayout as the container size changes.This change removes
FluentGridand instead uses flexbox layout directly.Note
This PR is to the
feature/dashpagesbranch, notmain.Before
After
Microsoft Reviewers: Open in CodeFlow