Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI scale with APIM #40250

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

AI scale with APIM #40250

wants to merge 12 commits into from

Conversation

diberry
Copy link
Contributor

@diberry diberry commented Mar 28, 2024

@diberry diberry requested a review from a team as a code owner March 28, 2024 20:01
@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 28, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Mar 28, 2024
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add to the TOC?

@jmatthiesen
Copy link
Contributor

General feedback for this page in all languages:

The option to Open in GitHub Codespaces opens Codespaces in the current window instead of an external window. It would be better to open externally so the document remains open and the reader can continue to follow along.

@jmatthiesen
Copy link
Contributor

Actually, looks links to samples also open in the current window. In general I'd prefer to have external windows open for any content that I want to have alongside the current document as I follow along.

For pages that move on to new topics, like the Next Steps links, those make sense to replace the current content.

@BillWagner
Copy link
Member

@gewarren

I think this one is ready now.

@gewarren
Copy link
Contributor

gewarren commented Apr 4, 2024

@diberry Are you ready to merge this?

@BillWagner BillWagner modified the milestones: March 2024, April 2024 Apr 5, 2024
@diberry diberry marked this pull request as draft May 2, 2024 14:33
@diberry
Copy link
Contributor Author

diberry commented May 2, 2024

@jmatthiesen I can't see that the .NET sample supports the required env vars. Can you verify that the .NET chat app support LB with these env vars? OPENAI_HOST and AZURE_OPENAI_CUSTOM_URL

@BillWagner BillWagner modified the milestones: April 2024, May 2024 May 3, 2024
@BillWagner BillWagner modified the milestones: May 2024, June 2024 Jun 3, 2024
@gewarren gewarren removed their assignment Jun 4, 2024
@BillWagner BillWagner modified the milestones: June 2024, July 2024 Jul 1, 2024
@BillWagner BillWagner modified the milestones: July 2024, August 2024 Aug 1, 2024
@BillWagner BillWagner modified the milestones: August 2024, September 2024 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants