Update streams-programming-apis.md implicit subscription section to b… #41988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e more clear Adds information regarding implementing IAsyncObserver<T> and IStreamSubscriptionObserver for Implicit Streams instead of explicitly subscribing (which does not apply in the case of an implicit subscription)
dotnet-policy-service
bot
added
the
community-contribution
snovak7
reviewed
Aug 1, 2024
|
@dotnet-policy-service agree |
IEvangelist
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
This looks good to me, but let's include @mikekistler to confirm.
mikekistler
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Looks good. 👍
I'll defer to @ReubenBond on the technical details, but I suggested one minor wording change.
Suggestion / Word Correction Co-authored-by: Mike Kistler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The section for Microsoft Orleans Streams Programming is missing information regarding how to implement Implicit Streams using the
IAsyncOberserverandIStreamSubscriptionObserverinterfaces. The documentation currently states that an explicit subscription is required, but implicit subscriptions can be supported by implementing two interfaces.Adds information regarding implementing IAsyncObserver and IStreamSubscriptionObserver for Implicit Streams instead of explicitly subscribing (which
does not applyis not required in the case of an implicit subscription)Internal previews