Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse version > 9 in dotnet.py #4470

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Parse version > 9 in dotnet.py #4470

wants to merge 7 commits into from

Conversation

am11
Copy link
Member

@am11 am11 commented Sep 20, 2024

A job run in PR dotnet/runtime#106599 is failing like https://dev.azure.com/dnceng-public/public/_build/results?buildId=813428&view=logs&j=3ca38e2b-df6d-5512-8718-3c103788a0f9&t=0d6eb74e-f21d-5060-4e66-099a24a67e5e

[2024/09/19 22:41:48][INFO] $ pushd "/mnt/vss/_work/1/performance"
[2024/09/19 22:41:48][INFO] $ popd
[2024/09/19 22:41:48][ERROR] Unexpected error: <class 'RuntimeError'>
[2024/09/19 22:41:48][ERROR] Traceback (most recent call last):
  File "/mnt/vss/_work/1/performance/scripts/run_performance_job.py", line 1187, in main
    run_performance_job(RunPerformanceJobArgs(**args))
  File "/mnt/vss/_work/1/performance/scripts/run_performance_job.py", line 768, in run_performance_job
    ci_setup.main(ci_setup_arguments)
  File "/mnt/vss/_work/1/performance/scripts/ci_setup.py", line 447, in main
    dotnet_version = dotnet.get_dotnet_version_precise(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
  File "/mnt/vss/_work/1/performance/scripts/performance/tracer.py", line 90, in wrapper
    return func(*args, **kwargs)
  File "/mnt/vss/_work/1/performance/scripts/dotnet.py", line 614, in get_dotnet_version_precise
    sdk = get_dotnet_version_from_path(framework, dotnet_path, sdk_path)
  File "/mnt/vss/_work/1/performance/scripts/performance/tracer.py", line 90, in wrapper
    return func(*args, **kwargs)
  File "/mnt/vss/_work/1/performance/scripts/dotnet.py", line 601, in get_dotnet_version_from_path
    raise RuntimeError(
RuntimeError: Unable to determine the .NET SDK used for net9.0

@am11
Copy link
Member Author

am11 commented Sep 20, 2024

cc @ilonatommy

@am11
Copy link
Member Author

am11 commented Sep 20, 2024

Apparently, printf wasn't showing up in CI logs, so I moved the diag to exception message. Please retry.

@am11
Copy link
Member Author

am11 commented Sep 20, 2024

Ah, so it is cloning the wrong repo :(

scripts/dotnet.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant