Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Treat -rtm as stable sdk version band #107997

Open
wants to merge 3 commits into
base: release/9.0
Choose a base branch
from
Open

[release/9.0] Treat -rtm as stable sdk version band #107997

wants to merge 3 commits into from
+6 −5

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 18, 2024 •
edited
Loading

@lewing lewing added the area-Workloads Workloads like wasm-tools label Sep 18, 2024
@lewing
Copy link
Member Author

lewing commented Sep 18, 2024

There may be more changes needed to fix wbt here

@lewing lewing mentioned this pull request Sep 18, 2024
Open
@carlossanlop
Copy link
Member

The CI failures seem related.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 19, 2024
carlossanlop
carlossanlop approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are gone. Tell-mode, adding servicing-approved.

Feel free to also wait for an area expert sign-off - @akoeplinger or @steveisok .

@lewing
Copy link
Member Author

lewing commented Sep 20, 2024

the remaining failures appear to be because dotnet/emsdk#940 needs to merge first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@lewing lewing

Labels
area-Build-mono area-Workloads Workloads like wasm-tools Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewing @carlossanlop