Update PingPongActivityTest.java #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified test to ignore linefeeds and white spaces in the test results. This will allow a test to pass even if a line feed or tab is in the wrong position.
|
In a Motorola Moto G the test would never pass without this fix. The number of spaces and \n characters vary between Android devices. Is it going to be merged at any moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified test to ignore linefeeds and white spaces in the test results.
This will allow a test to pass even if a line feed or tab is in the wrong position.
Initially I inserted my line feed before the output string. This change will allow before, after or no linefeed to pass. I admit no linefeed would result in an ugly display, but the underlying code would still be functionally correct.