Add dynamic ResourceItemDescriptors #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR allows creation of ResourceItemsDescriptors from `generic/items` JSON files. Works the same as the items defined in C++ code. Dynamic items are only added if they aren't already defined. Later on we can remove items defined in C++ code, but need to reroute const char* suffix pointers like `RStateOn`. The PR also defines the items described in dresden-elektronik#6673 (comment) Update measured_value items according to discussion Remove measure_value items from this PR
manup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creation of
ResourceItemsDescriptorfromgeneric/itemsJSON files. Works the same as the items defined in C++ code.Dynamic items are only added if they aren't already registered. Later on we can remove items defined in C++ code, but need to reroute
const char*suffix pointers likeRStateOn.