Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #32

Merged
merged 16 commits into from
Jul 21, 2023
Merged

Dev #32

merged 16 commits into from
Jul 21, 2023

Conversation

tamzi
Copy link
Contributor

@tamzi tamzi commented Jul 20, 2023


!!! BIG PR: Major changes to Chai:

  • update to k1.9 and jetpack compose 1.5.0
  • Create lint library for Chai design system

How can this PR be tested?

Please describe how the reviewers can test your changes here. i.e _To test it:

  • Check out project on pc, build it and run it.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure your branch is up to date with develop branch.
  • Ensure your branch runs without breaking.
  • Ensure you solved any merge conflicts.
  • Smaller PRs for the ease of reviewing
  • Ensure the tests and linter pass (./gradlew --init-script gradle/init.gradle.kts spotlessApply to automatically apply formatting)
  • Appropriate docs were updated (You are adding code so...)
  • Tests have been written

Is this your first Pull Request?

  • Run ./tools/setup.sh
  • Import the code formatting style as explained in the setup script.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@tamzi tamzi merged commit e274342 into main Jul 21, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants