Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup build logic #37

Closed
wants to merge 3 commits into from
Closed

Setup build logic #37

wants to merge 3 commits into from

Conversation

kibettheophilus
Copy link


name: Pull request
about: Create a pull request
label: 'triage me'
Fixes Referenced Issue #.


How can this PR be tested?

Please describe how the reviewers can test your changes here. i.e To test it Log
off the internet


Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure your branch is up to date with develop branch.
  • Ensure your branch runs without breaking.
  • Ensure you solved any merge conflicts.
  • Smaller PRs for the ease of reviewing
  • Make sure to open a GitHub issue as a bug/feature request before writing your code! This means that we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass (./gradlew --init-script gradle/init.gradle.kts spotlessApply to automatically apply formatting)
  • Appropriate docs were updated (You are adding code so...)
  • Tests have been written

Is this your first Pull Request?

  • Run ./tools/setup.sh
  • Import the code formatting style as explained in the setup script.

Fixes #<issue_number_goes_here> 🦕

Screenshot

N/A

@github-actions
Copy link

github-actions bot commented Jul 30, 2023

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unstable API Usage 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@tamzi
Copy link
Contributor

tamzi commented Jul 15, 2024

@kibettheophilus still updating this?

@kibettheophilus
Copy link
Author

kibettheophilus commented Jul 17, 2024

@kibettheophilus still updating this?

Yes, I had forgotten about it...will finish it

@tamzi
Copy link
Contributor

tamzi commented Aug 10, 2024

worth revisiting @kibettheophilus :)

@kibettheophilus
Copy link
Author

@tamzi do we still really need to setup up this, because we have only 3 modules.

thoughts @MamboBryan ?

@MamboBryan
Copy link
Contributor

@tamzi do we still really need to setup up this, because we have only 3 modules.

thoughts @MamboBryan ?

I think we don't really need it and can close it for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants