Feature : Typography #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rating typography class
tamzi
requested changes
Sep 2, 2024
| @@ -0,0 +1,45 @@ | |||
| # Typography | |||
| This is a simple doc that should be used in line with the typography tokens in the design system | |||
There was a problem hiding this comment.
Replace with:
These are the typography tokens in the design system.
| Example: | ||
| If you have an app with two screens, characters and character, where characters shows a list of people and character shows the details of one person. | ||
| You can use title for Characters and Character . | ||
|
|
|
|
||
| ### Display | ||
| This is the token to use when you want to highlight or make any content stand out. It should not be used as a header, title or body text. | ||
|
|
There was a problem hiding this comment.
Missing code sample. for the others
| import com.droidconke.chai.utils.ChaiPreview | ||
|
|
||
| private val DUMMY_CHAI_TEXT = "Design systems provide guidelines and reusable components to ensure consistent and efficient design across digital products, improving user experience and streamlining team workflows." | ||
|
|
There was a problem hiding this comment.
Would it make sense to use an inline doc here... showing how we use the specific composable
| @@ -27,8 +27,7 @@ import androidx.compose.ui.text.style.TextAlign | |||
| import androidx.compose.ui.text.style.TextOverflow | |||
| import androidx.compose.ui.unit.sp | |||
| import com.droidconke.chai.atoms.* | |||
| import com.droidconke.chai.atoms.MontserratRegular | |||
| import com.droidconke.chai.atoms.MontserratThin | |||
| import com.droidconke.chai.atoms.MontserratSans | |||
| import com.droidconke.chai.chaiColorsPalette | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Is this inline doc up to date?
janewaitara
reviewed
Sep 2, 2024
…nes, configures button tokens
janewaitara
approved these changes
Sep 4, 2024
tamzi
requested changes
Sep 5, 2024
tamzi
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
label: 'triage me'
Fixes #53
Fixes #60
How can this PR be tested?
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
./gradlew --init-script gradle/init.gradle.kts spotlessApplyto automatically apply formatting)Is this your first Pull Request?
./tools/setup.shFixes #<issue_number_goes_here> 🦕
Screenshot