Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow #61

Closed
wants to merge 2 commits into from
Closed

Update workflow #61

wants to merge 2 commits into from

Conversation

kibettheophilus
Copy link

@kibettheophilus kibettheophilus commented Sep 22, 2024

  • Removed the job for cancelling previous workflows, this is not needed as a job or using external action since GitHub provides a way to cancel out of the box. Read more on Concurrency.
  • Removed the trigger for on push to main since this felt like a double run which consumes the minutes twice(with the assumption that all code changes will be made via a pull request).
  • Update the flow and dependency between jobs, only build can be done after all the other jobs are successful. This will make it easy to track all the failures in a single run. In the previous impl, if androidTest and test had failures, you first had to fix test then wait for the second run to be able to catch failures in the androidTest.
    • This also reduces the time the workflow takes to run because the child jobs run in parallel, it only took 3mins while the previous impl took 4mins+, check on compare on actions

Evidence kwa kalatas

  1. Cancelled workflow when a new one was triggered
Screenshot 2024-09-22 at 08 20 33
  1. Re-organization of the jobs
Screenshot 2024-09-22 at 08 20 53

I am open for discussion 😄

@MamboBryan
Copy link
Contributor

MamboBryan commented Sep 23, 2024

@kibettheophilus I thought creating a waterfall of actions would be better than running all 3 independently and then running build later. My thought was : if the app doesn't pass linting don't even run testing, let it pass the previous phase so that it can proceed to the next phase.
CC : @tamzi @janewaitara thoughts

@kibettheophilus
Copy link
Author

@kibettheophilus I thought creating a waterfall of actions would be better than running all 3 independently and then running build later. My thought was : if the app doesn't pass linting don't even run testing, let it pass the previous phase so that it can proceed to the next phase. CC : @tamzi @janewaitara thoughts

@MamboBryan I see your POV.

@MamboBryan
Copy link
Contributor

Way forward on this @kibettheophilus ?

@kibettheophilus
Copy link
Author

Way forward on this @kibettheophilus ?

I was waiting to hear from @tamzi @janewaitara about their opinions, but I can just close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants