Setup codecov #284
Merged
Setup codecov #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raynafs
requested review from
chepsi,
wangerekaharun,
michaelbukachi,
jumaallan,
kibettheophilus,
misshannah and
MamboBryan
as code owners
|
@chepsi still working on this. Don't understand why it automatically assigns reviewers |
@Raynafs the reviewers are requested automatically because of Code Owners, you can however convert the PR to draft if it is not ready for review |
|
Thanks @kibettheophilus |
|
@Raynafs I have fixed the failing CI with my latest merge please rebase from develop |
|
@chepsi @kibettheophilus This is ready, just needs to be tested in codecov. |
chepsi
reviewed
Jun 13, 2024
chepsi
approved these changes
Jun 13, 2024
kibettheophilus
approved these changes
Jun 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Please make sure to read the Contribution Guidelines
and check that you understand and have followed it as best as possible Explain what your feature
does in a short paragraph. please check the below boxes
./codeAnalysis.shon linux/unix orcodeAnalysys.baton windows to make sure all lint/formatting checks have been done.#283
Declare any issues by typing
fixes #1orcloses #1for example so that the automation can kickin when this is merged
Other testing QA Notes
What have you tested specifically and what possible impacts/areas there are that may need retesting
by others.
Please add a screenshot (if necessary)