Sanitize user names on sql-sanitize. #6057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Ideally we add test coverage for this. We can probably add on tgo an existing test. |
andriokha
reviewed
Jul 9, 2024
|
|
||
| // Updates usernames to the pattern user_%uid. | ||
| $query | ||
| ->condition($uid_column, 0, '>') |
There was a problem hiding this comment.
That condition's already added further up.
Suggested change
| ->condition($uid_column, 0, '>') |
| // Updates usernames to the pattern user_%uid. | ||
| $query | ||
| ->condition($uid_column, 0, '>') | ||
| ->expression($name_column, "CONCAT('user_', $uid_column)"); |
There was a problem hiding this comment.
Looking at the email code, it appears we'd need a different format for different DB drivers I think?
Comment on lines
+89
to
+91
| [$name_table, $name_column] = $this->getFieldTableDetails('user', 'name'); | ||
| [$uid_table, $uid_column] = $this->getFieldTableDetails('user', 'uid'); | ||
| assert($uid_table === $name_table); |
There was a problem hiding this comment.
FWIW to my mind this clashes a little with the existing style where the table and column names have been hardcoded. Not sure if that means it's better to stick with the current style or update the others personally (:
If we do keep it, I think we need to catch any exceptions, we don't want to explode the sanitize command as a whole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4609