Introduce fix to archive failed queries on run_sql call #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Feb 28, 2024
RichardKeo
reviewed
Feb 28, 2024
RichardKeo
approved these changes
Feb 28, 2024
Co-authored-by: Richard Keo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey hey!
I reported it on Slack, but basically I ran into a case where when using the
run_sqlquery call, if the query fails we do not archive it. This resulted in me creating a bunch of broken queries and hitting the "private query limit" on the Dune account.I've tried to introduce a simple fix here, but not 100% sure if this might be present elsewhere in the code.
🚀 keep up the amazing work