fix(menus): Do not create menu item if parent cannot be found

dvanoni · Aug 25, 2024 · b339fcc · b339fcc
1 parent feddb28
commit b339fcc
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/content/services/ui-manager.ts b/src/content/services/ui-manager.ts
@@ -88,16 +88,16 @@ export class UIManager implements Service {
     parentId: string;
     window: Zotero.ZoteroWindow;
   }): XUL.MenuItemElement | null {
-    let menuItem = createXULElement(window.document, 'menuitem');
-    menuItem.setAttribute('label', getLocalizedString(labelName));
-    menuItem.addEventListener('command', onCommand);
-
     const parentMenu = window.document.getElementById(parentId);
     if (!parentMenu) {
       logger.error(`Failed to find element '${parentId}'`);
       return null;
     }
 
+    let menuItem = createXULElement(window.document, 'menuitem');
+    menuItem.setAttribute('label', getLocalizedString(labelName));
+    menuItem.addEventListener('command', onCommand);
+
     menuItem = parentMenu.appendChild(menuItem);
     this.addManagedNode(window, menuItem);