Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow debug memory problems #80

Open
wants to merge 1,250 commits into
base: latest
Choose a base branch
from
Open

Conversation

mingodad
Copy link

usage: make V=1 DEBUG=1 DBGWRAPPER=valgrind DISABLE_MEMMGR=1 DESTDIR=$HOME/local

redj and others added 30 commits November 28, 2020 15:15
… cpp types in method callers. remove assert and debug print noise.
…uct class parameter to be able to pass null. handle name clash between lowercased method and property names. remove some brokens and add others.
…ration. fix global function symbol collision between C and C++.
@jerstlouis jerstlouis force-pushed the latest branch 11 times, most recently from 5a88997 to 414480b Compare January 26, 2022 10:21
@jerstlouis
Copy link
Member

Hi @mingodad, wondering if you had a chance to figure out what issue that you ran into was?

As I had mentioned, I think it likely had to do with a memory management mix-up.

In your PR, I see usage of malloc_usable_size() but that will not work properly as that does not return the size that was requested.

(I have made that mistake before).

We cannot merge these changes to use regular malloc/calloc/realloc when _DEBUG is defined because of this, and also because the code should go through the regular pathways which supports our own MemoryGuard memory checker and the eC which makes a huge performance difference for small allocation on Windows platforms.

Please let me know if I can be of further help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants