Improve rename tests so they can work with Javac too #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaohaizh since you authored those tests, can you please review and confirm my interpretation that the syntax error is not intentionally included in test? |
|
test this please |
1 similar comment
|
test this please |
The current code being tested has syntax errors. Those errors prevents Javac from properly setting up bindings (and it's not obvious that Javac is more wrong than ECJ, so there are little chance Javac gets changed to behave like ECJ). Those syntax errors do not seem so relevant for the case being covered. So we get rid of them to focus on the "correct" case and allow Javac to work with it.
rgrunber
force-pushed
the
syntax-errors-in-name
branch
from
e72eafe
to
6510deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code being tested has syntax errors. Those errors prevents Javac from properly setting up bindings (and it's not obvious that Javac is more wrong than ECJ, so there are little chance Javac gets changed to behave like ECJ).
Those syntax errors do not seem so relevant for the case being covered. So we get rid of them to focus on the "correct" case and allow Javac to work with it.