Remove CRIU Interpreter #20177
Open
Remove CRIU Interpreter #20177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @tajila. If we can merge #19754, I'll amend this patch with whatever is required w.r.t. #19835 (comment) |
ThanHenderson
force-pushed
the
criu-dbg
branch
2 times, most recently
from
084b132
to
bb81832
Compare
ThanHenderson
commented
Sep 17, 2024
tajila
reviewed
Sep 18, 2024
tajila
reviewed
Sep 18, 2024
ThanHenderson
force-pushed
the
criu-dbg
branch
from
bb81832
to
6389180
Compare
|
I've added a If we are good with the patch, I'll just need to add tests in |
ThanHenderson
force-pushed
the
criu-dbg
branch
from
6389180
to
419b2a9
Compare
- Remove CRIUBytcodeInterpreterCompressed - Remove CRIUBytcodeInterpreterFull - Add J9VM_CRIU_TRANSITION_TO_DEBUG_INTERPRETER flag - Add criuRestoreCheckForDebugInterpreterRequest hook - Add criuRestoreCheckForJdwp hook - Set transition flag if -Xdump, -Xtrace, or JDWP is specified - checkTransitionToDebugInterpreter becomes infallible - Call checkTransitionToDebugInterpreter after restore hooks Issues: eclipse-openj9#19835 Signed-off-by: Nathan Henderson <[email protected]>
ThanHenderson
force-pushed
the
criu-dbg
branch
from
419b2a9
to
80ea800
Compare
|
Note: this will have to be double-delivered for the 0.48 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIUBytcodeInterpreterCompressedCRIUBytcodeInterpreterFullJ9VM_CRIU_TRANSITION_TO_DEBUG_INTERPRETERflagcriuRestoreCheckForDebugInterpreterRequesthook-Xdump,-Xtrace, orJDWPis specifiedcheckTransitionToDebugInterpreterbecomes infalliblecheckTransitionToDebugInterpreterafter restore hooksIssues: #19835
Signed-off-by: Nathan Henderson [email protected]