-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add modify ui. #721
Merged
swaroopar
merged 1 commit into
eclipse-xpanse:main
from
Alice1319:feature/add_modify_for_myservices
Apr 24, 2024
Merged
add modify ui. #721
swaroopar
merged 1 commit into
eclipse-xpanse:main
from
Alice1319:feature/add_modify_for_myservices
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alice1319
force-pushed
the
feature/add_modify_for_myservices
branch
3 times, most recently
from
April 17, 2024 08:20
2716910
to
af78526
Compare
swaroopar
requested changes
Apr 17, 2024
src/components/content/deployedServices/myServices/modify/Modify.tsx
Outdated
Show resolved
Hide resolved
src/components/content/deployedServices/myServices/modify/Scale.tsx
Outdated
Show resolved
Hide resolved
src/components/content/deployedServices/myServices/modify/ScaleOrModifySubmitStatusAlert.tsx
Outdated
Show resolved
Hide resolved
src/components/content/deployedServices/myServices/modify/Modify.tsx
Outdated
Show resolved
Hide resolved
src/components/content/deployedServices/myServices/modify/Scale.tsx
Outdated
Show resolved
Hide resolved
Alice1319
force-pushed
the
feature/add_modify_for_myservices
branch
from
April 17, 2024 08:47
af78526
to
fc47213
Compare
swaroopar
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alice1319 Please also check why flavor and service name is not updated in backend after modification is completed.
Alice1319
force-pushed
the
feature/add_modify_for_myservices
branch
from
April 18, 2024 07:27
fc47213
to
3e251aa
Compare
swaroopar
requested changes
Apr 18, 2024
src/components/content/deployedServices/myServices/MyServices.tsx
Outdated
Show resolved
Hide resolved
Alice1319
force-pushed
the
feature/add_modify_for_myservices
branch
from
April 23, 2024 06:17
a2f163c
to
f2bdf57
Compare
Alice1319
force-pushed
the
feature/add_modify_for_myservices
branch
from
April 24, 2024 01:41
f2bdf57
to
3dfaf10
Compare
swaroopar
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes eclipse-xpanse/xpanse#1516