chore(apps): Set app tokens #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leomp12 uma dúvida nesse app do flash courier o contrato poderia ser todo um secret, ou deveriamos salvar cada um como secret aqui ? |
É muita coisa né ? 🙃 |
wisley7l
force-pushed
the
chore/set-app-tokens
branch
from
59e1e07
to
b04ea58
Compare
wisley7l
changed the title
leomp12
reviewed
Jun 27, 2023
action.yml
Outdated
| galaxpay-hash: | ||
| description: 'App: Galax Pay hash' | ||
| ga-api-token: | ||
| description: 'App: Google analytics API secret' |
There was a problem hiding this comment.
Suggested change
| description: 'App: Google analytics API secret' | |
| description: 'App: Google Analytics API secret' |
action.yml
Outdated
Comment on lines
63
to
66
| pagarme-encry-key: | ||
| description: 'App: PagarMe Encryption Key' | ||
| pagarme-token: | ||
| description: 'App: PagarMe API token' |
There was a problem hiding this comment.
Suggested change
| pagarme-encry-key: | |
| description: 'App: PagarMe Encryption Key' | |
| pagarme-token: | |
| description: 'App: PagarMe API token' | |
| pagarme-encrypt-key: | |
| description: 'App: Pagar.me encryption Key' | |
| pagarme-token: | |
| description: 'App: Pagar.me API token' |
action.yml
Outdated
Comment on lines
73
to
74
| webhook-app-token: | ||
| description: 'App: Webhooks App Token' |
There was a problem hiding this comment.
Suggested change
| webhook-app-token: | |
| description: 'App: Webhooks App Token' | |
| webhooks-token: | |
| description: 'App: Webhooks token' |
| let headers: { Authorization: string; } | undefined; | ||
|
|
||
| if (token) { | ||
| if (!process.env.WEBHOOKAPP_TOKEN) { |
There was a problem hiding this comment.
Suggested change
| if (!process.env.WEBHOOKAPP_TOKEN) { | |
| if (!process.env.WEBHOOKS_TOKEN) { |
| if (!process.env.WEBHOOKAPP_TOKEN) { | ||
| const webhookAppToken = options.webhook_token | ||
| if (typeof webhookAppToken === 'string' && webhookAppToken) { | ||
| process.env.WEBHOOKAPP_TOKEN = webhookAppToken; |
There was a problem hiding this comment.
Suggested change
| process.env.WEBHOOKAPP_TOKEN = webhookAppToken; | |
| process.env.WEBHOOKS_TOKEN = webhookAppToken; |
| @@ -25,7 +26,25 @@ export default (data: AppModuleBody) => { | |||
| ...application.hidden_data, | |||
| }; | |||
|
|
|||
| if (!configApp.pagarme_encryption_key || !configApp.pagarme_api_key) { | |||
| if (!process.env.PAGARME_ENCRYP_KEY) { | |||
There was a problem hiding this comment.
Suggested change
| if (!process.env.PAGARME_ENCRYP_KEY) { | |
| if (!process.env.PAGARME_ENCRYPT_KEY) { |
| if (!process.env.PAGARME_ENCRYP_KEY) { | ||
| const parameEncrypKey = configApp.pagarme_encryption_key; | ||
| if (typeof parameEncrypKey === 'string' && parameEncrypKey) { | ||
| process.env.PAGARME_ENCRYP_KEY = parameEncrypKey; |
There was a problem hiding this comment.
Suggested change
| process.env.PAGARME_ENCRYP_KEY = parameEncrypKey; | |
| process.env.PAGARME_ENCRYPT_KEY = parameEncrypKey; |
| } | ||
| } | ||
|
|
||
| if (!process.env.PAGARME_ENCRYP_KEY || !process.env.PAGARME_TOKEN) { |
There was a problem hiding this comment.
Suggested change
| if (!process.env.PAGARME_ENCRYP_KEY || !process.env.PAGARME_TOKEN) { | |
| if (!process.env.PAGARME_ENCRYPT_KEY || !process.env.PAGARME_TOKEN) { |
| @@ -137,7 +156,7 @@ export default (data: AppModuleBody) => { | |||
| // https://github.com/pagarme/pagarme-js | |||
| gateway.js_client = { | |||
| script_uri: 'https://assets.pagar.me/pagarme-js/4.8/pagarme.min.js', | |||
| onload_expression: `window._pagarmeKey="${configApp.pagarme_encryption_key}"; | |||
| onload_expression: `window._pagarmeKey="${process.env.PAGARME_ENCRYP_KEY}"; | |||
There was a problem hiding this comment.
Suggested change
| onload_expression: `window._pagarmeKey="${process.env.PAGARME_ENCRYP_KEY}"; | |
| onload_expression: `window._pagarmeKey="${process.env.PAGARME_ENCRYPT_KEY}"; |
| logger.warn('Missing GalaxPay ID'); | ||
| } | ||
| } | ||
|
|
||
| const measurementId = appData.measurement_id; |
There was a problem hiding this comment.
Não tinha que ter um env opcional pra esse ID também?
There was a problem hiding this comment.
Quer dizer, só a API key sem esse ID é inútil né?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.