add ego_largeheap build tag as workaround for heap sizes larger than 16GB #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ego-docs canceled.
|
daniel-weisse
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#201 introduced a regression that causes memory allocations above 16GB to fail. This was reported in #226. It's difficult to support both a small minimal heap size and very large heap sizes within the same built binary.
As a workaround, we introduce the
ego_largeheapbuild tag. For most users, the default behavior (small minimal requirements, up to 16GB heap) should be fine. Users wanting larger heap sizes can build their apps with the new build tag.On signing, the CLI informs the user in case a rebuild with this tag is required.